Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exact search matches at the top of the search list #8818

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Apr 28, 2022

Fixed Issues

$ #8763

Tests and QA

Create two additional users with similar usernames:

  1. Start a chat with newuser and send a message
  2. Now go to search chats and type "user@"
  3. Verify that newuser@expensify.com is shown at the top of the list (because of the recent message you sent them)
  4. Now keep typing the full email address for "user@expensify.com"
  5. Verify that now user@expensify.com is shown at the top of the list once it's a perfect match with the search term
  • Verify that no errors appear in the JS console

QA Steps

Same as tests

Screenshots

Web

2022-04-28_11-38-10.mp4

Mobile Web

2022-04-28_11-32-14.mp4

Desktop

2022-04-28_11-40-35.mp4

iOS

2022-04-28_13-39-21.mp4

Android

2022-04-28_13-36-11.mp4

@tgolen tgolen requested a review from Julesssss April 28, 2022 17:50
@tgolen tgolen requested a review from marcaaron as a code owner April 28, 2022 17:50
@tgolen tgolen self-assigned this Apr 28, 2022
@marcaaron marcaaron removed their request for review April 28, 2022 18:04
@tgolen
Copy link
Contributor Author

tgolen commented Apr 28, 2022

All right, updated with videos of iOS and Android.

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Julesssss Julesssss merged commit fe432c3 into main Apr 29, 2022
@Julesssss Julesssss deleted the tgolen-fix-search branch April 29, 2022 10:00
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 9, 2022

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants